Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for number of users per page (pagination) #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fabwu
Copy link

@fabwu fabwu commented Aug 14, 2014

No description provided.

@stijnhau
Copy link

Seems like a good welcome change.
Except the view keep telling next 10 shoudl be the value from the moduleOption class.

@stijnhau stijnhau mentioned this pull request Aug 15, 2014
@fabwu
Copy link
Author

fabwu commented Aug 15, 2014

I believe this button means the next 10 pages and not the next 10 items...

In my project I replace this button with a link to the next page. Do you want this?

@stijnhau
Copy link

No realy means next 10 items(users).

@stijnhau
Copy link

Can you also change it in the view?

@fabwu
Copy link
Author

fabwu commented Aug 26, 2014

As you can see in the comment this link mean the next 10 pages. But you can create a seperate PR with your feature.

<!-- Previous page link -->
<li<?php echo (isset($this->previous)) ? '' : ' class="disabled"'; ?>>
    <a href="<?php echo $this->url('zfcadmin/zfcuseradmin/list', array('p' => $this->previous-9)); ?>">&lt; Previous 10</a>
</li>

@fabwu
Copy link
Author

fabwu commented Aug 31, 2014

@Danielss89 Can you clarify the meaning of this link, please?

@stijnhau
Copy link

stijnhau commented May 3, 2015

@Danielss89
Any comment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants